Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: Import Impala's blocked based BloomFilter ...................................................................... Patch Set 1: (3 comments) I just glanced over, not trying to understand the essence. It seems importing this comes which duplication of some utilities which are in the Kudu's codebase already. http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/bloom-filter.h File src/kudu/impala/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/bloom-filter.h@22 PS1, Line 22: #include <stddef.h> : #include <stdint.h> nit for here and other files: consider using C++ headers, such as cstddef and cstdint instead http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/cpu-info.cc File src/kudu/impala/util/cpu-info.cc: http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/cpu-info.cc@156 PS1, Line 156: #if !defined(__APPLE__) All the code above for /proc/cpuinfo in this method doesn't work on macOS, so I'm curious why only sched_getcpu() is put under ifdef (probably, just to avoid build failures?) BTW, it's possible to extract that information using sysctl like the existing code in CpuInfo::GetCacheInfo() (corresponding names of the sysctl variables are machdep.cpu.* like machdep.cpu.features for flags (but they are uppercase in case of macOS), and frequency can be retrieved from hw.cpufrequency) http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/pretty-printer.h File src/kudu/impala/util/pretty-printer.h: PS1: Is it possible to use utilities from gutil/strings/human_readable.h instead of importing these? -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 20:50:26 +0000 Gerrit-HasComments: Yes
