Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: Import Impala's blocked based BloomFilter ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG@14 PS1, Line 14: : Created a separate sub-directory kudu/impala/util : and retained impala namespace to distinguish : between existing kudu BloomFilter and this one. > This is will be tricky If I were you I'd fully kudu-ify the code - i.e. prune out unnecessary stuff and use Kudu utilities where appropriate - and not worry about making it consumable by Impala. We do need to be sure the binary representation is the same, but I think we can accomplish that with inspection and testing. -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 21:52:59 +0000 Gerrit-HasComments: Yes
