Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: Import Impala's blocked based BloomFilter ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG@12 PS1, Line 12: Plan is to use this BloomFilter for pushing down : predicate from Impala. Will you also evaluate whether Impala's BF could be used in Kudu's diskrowset BFs? We can't change the on-disk BF format (well, we can, but would need to do so in a backwards compatible way), but perhaps we can adapt the on-disk state into Impala's BF in memory? http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG@14 PS1, Line 14: : Created a separate sub-directory kudu/impala/util : and retained impala namespace to distinguish : between existing kudu BloomFilter and this one. Since Impala consumes kudu_util, would it be possible to incorporate the Impala bloom filter into kudu_util (leveraging existing Kudu dependencies as needed), drop it from Impala altogether, and have Impala get it via its kudu_util dependency? I'm a little hesitant to add those Impala dependencies into Kudu, especially if there exists a way to solve this problem without doing so. http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/compiler-util.h File src/kudu/impala/util/compiler-util.h: PS1: We have a bunch (if not all) of this already in gutil/macros.h, gutil/port.h, and likely other headers in gitul. http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/cpu-info.cc File src/kudu/impala/util/cpu-info.cc: PS1: Likewise this may overlap somewhat with gutil/cpu.{cc,h} and gutil/sysinfo.{cc,h} http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/pretty-printer.h File src/kudu/impala/util/pretty-printer.h: PS1: Subsumed by gutil/strings/human_readable.{cc,h}? -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 20:58:33 +0000 Gerrit-HasComments: Yes
