Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14745 )
Change subject: Import Impala's blocked based BloomFilter ...................................................................... Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG@12 PS1, Line 12: Added this BF as part of kudu-util and renamed to BlockBloomFilter to avoid name collision : with existing BloomFil > Will you also evaluate whether Impala's BF could be used in Kudu's diskrows Sure. I can look into this as a follow-up. http://gerrit.cloudera.org:8080/#/c/14745/1//COMMIT_MSG@14 PS1, Line 14: : Removed dependencies on generated code like Thrift/Protobuf, Impala specific : utilities like BufferPool, CPUInfo. : > Works for me. Done http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/bloom-filter.h File src/kudu/impala/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/bloom-filter.h@22 PS1, Line 22: : > nit for here and other files: consider using C++ headers, such as cstddef a Done http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/compiler-util.h File src/kudu/impala/util/compiler-util.h: PS1: > We have a bunch (if not all) of this already in gutil/macros.h, gutil/port. Done http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/cpu-info.cc File src/kudu/impala/util/cpu-info.cc: PS1: > Likewise this may overlap somewhat with gutil/cpu.{cc,h} and gutil/sysinfo. Done http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/cpu-info.cc@156 PS1, Line 156: > All the code above for /proc/cpuinfo in this method doesn't work on macOS, Done http://gerrit.cloudera.org:8080/#/c/14745/1/src/kudu/impala/util/pretty-printer.h File src/kudu/impala/util/pretty-printer.h: PS1: > Subsumed by gutil/strings/human_readable.{cc,h}? Done -- To view, visit http://gerrit.cloudera.org:8080/14745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c54a051c5093cf5fb81481a47a0a6677d7d906 Gerrit-Change-Number: 14745 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2019 18:04:54 +0000 Gerrit-HasComments: Yes
