Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: [master] KUDU-3016 don't lump together updates on all tablet reports ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14897/6/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14897/6/src/kudu/master/sys_catalog.cc@838 PS6, Line 838: size_t req_size = req->ByteSizeLong(); > Could we just recompute this after adding each tablet instead of all that e Yup, it seems calling ByteSizeLong() every iteration is expensive since it's O(n^2) computational complexity w.r.t. size of the packet. This approach already computes deltas of the size change, and that's fast and the sizes are computed anyways while performing actual memcopy() in Add() implementation. I think I'll switch to an approach I outlined in https://gerrit.cloudera.org/#/c/14897/4/src/kudu/common/row_operations.h@56 -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 10 Jan 2020 20:16:06 +0000 Gerrit-HasComments: Yes
