ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14911 )
Change subject: KUDU-3021 Add metric for tablet transaction memory. ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/tablet/transactions/transaction_tracker-test.cc File src/kudu/tablet/transactions/transaction_tracker-test.cc: http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/tablet/transactions/transaction_tracker-test.cc@281 PS1, Line 281: NO_FATALS(CheckMemTracker(t, min_memory_limit)); > Could you refactor this with TestTooManyTransactions to avoid duplicating a ok :) http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/tablet/transactions/transaction_tracker.cc@74 PS1, Line 74: "of an ancestral tracker.", > of an ancestral tracker. Done http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/util/atomic.h File src/kudu/util/atomic.h: PS1: > "Iff" isn't a typo; it means "if and only if" hhhhh, my mistake. Thanks for the link reference :) http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/util/high_water_mark.h File src/kudu/util/high_water_mark.h: http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/util/high_water_mark.h@47 PS1, Line 47: return current_value() + delta <= max; : } : > I appreciate the symmetry with TryIncrementBy, but I think this would be cl Done http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/util/mem_tracker.h File src/kudu/util/mem_tracker.h: http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/util/mem_tracker.h@116 PS1, Line 116: // Check if this tracker itself can consume those bytes, it will not increase : // the consumption of the tracker. : // Returns true if this tr > Returns true if this tracker could consume 'bytes' without exceeding its li Done http://gerrit.cloudera.org:8080/#/c/14911/1/src/kudu/util/mem_tracker.h@119 PS1, Line 119: // limit, false otherwise. > Maybe "CanConsumeNoAncestors" would be clearer? Good. I have been tangled for the name for a while. -- To view, visit http://gerrit.cloudera.org:8080/14911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I131b9ed27617274c1210a1678c1fdf7307b7edcc Gerrit-Change-Number: 14911 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 15:27:18 +0000 Gerrit-HasComments: Yes
