Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14911 )
Change subject: KUDU-3021 Add metric for tablet transaction memory. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/tablet/transactions/transaction_tracker-test.cc File src/kudu/tablet/transactions/transaction_tracker-test.cc: http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/tablet/transactions/transaction_tracker-test.cc@242 PS2, Line 242: // First is the root tracker memory limit and the second is current tracker memory limit. Could you duplicate this comment right before INSTANTIATE_TEST_CASE_P? Seems like it'd be useful there too. http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/util/mem_tracker.h File src/kudu/util/mem_tracker.h: http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/util/mem_tracker.h@116 PS2, Line 116: // Check if this tracker itself can consume those bytes, it will not increase : // the consumption of the tracker. Don't need this anymore; it's superceded by the "Returns true..." section of the comment. -- To view, visit http://gerrit.cloudera.org:8080/14911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I131b9ed27617274c1210a1678c1fdf7307b7edcc Gerrit-Change-Number: 14911 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 17:34:39 +0000 Gerrit-HasComments: Yes
