ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14911 )
Change subject: KUDU-3021 Add metric for tablet transaction memory. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/tablet/transactions/transaction_tracker-test.cc File src/kudu/tablet/transactions/transaction_tracker-test.cc: http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/tablet/transactions/transaction_tracker-test.cc@242 PS2, Line 242: // First is the root tracker memory limit and the second is current tracker memory limit. > Could you duplicate this comment right before INSTANTIATE_TEST_CASE_P? Seem Done http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/util/mem_tracker.h File src/kudu/util/mem_tracker.h: http://gerrit.cloudera.org:8080/#/c/14911/2/src/kudu/util/mem_tracker.h@116 PS2, Line 116: // Returns true if this tracker could consume 'bytes' without exceeding its : // limit, false otherwise. > Don't need this anymore; it's superceded by the "Returns true..." section o Done -- To view, visit http://gerrit.cloudera.org:8080/14911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I131b9ed27617274c1210a1678c1fdf7307b7edcc Gerrit-Change-Number: 14911 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2019 15:40:48 +0000 Gerrit-HasComments: Yes
