ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14911 )
Change subject: KUDU-3021 Add metric for tablet transaction memory. ...................................................................... Patch Set 4: > > > Still got IWYU errors to iron out though. > > > > Have take a look about the IWYU warning, I think it is ok to have > all public member in a struct. > > Yeah those are clang-tidy warnings that can be ignored; I'm > referring to the IWYU build failures, which requires rejiggering of > a few includes. I've done that and uploaded a new revision. Oh I get that, thanks a lot~ -- To view, visit http://gerrit.cloudera.org:8080/14911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I131b9ed27617274c1210a1678c1fdf7307b7edcc Gerrit-Change-Number: 14911 Gerrit-PatchSet: 4 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Sat, 21 Dec 2019 02:33:21 +0000 Gerrit-HasComments: No
