Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14912 )

Change subject: [tablet] Add new metrics to indicate the last read/write time
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14912/5/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:

http://gerrit.cloudera.org:8080/#/c/14912/5/src/kudu/tablet/tablet.h@663
PS5, Line 663:   // uint64_t::max is returned if this tablet hasn't been read 
since tablet created or tserver
             :   // restarted.
> It seems there another pitfall in using these metrics even without replicat
Recency of writes is maintained across all replicas because the write metric 
measures the time since applying a write op, which happens on all replicas 
during a write.

It's trickier on read though since we only read from a single replica.



--
To view, visit http://gerrit.cloudera.org:8080/14912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90738ba90eaa8f78c8d721dde2eed2b723d5572d
Gerrit-Change-Number: 14912
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 18 Dec 2019 21:37:47 +0000
Gerrit-HasComments: Yes

Reply via email to