Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14912 )
Change subject: [metrics] Add new metrics to indicate the last read/write time ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.h@282 PS3, Line 282: // Last read operation elapsed in seconds on this tablet. : uint64_t LastReadElapsedSeconds() const; : : // Last write operation elapsed in seconds on this tablet. : uint64_t LastWriteElapsedSeconds() const; : Can these be private? http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.h@761 PS3, Line 761: MonoTime last_write_time_; : mutable MonoTime last_read_time_; These need to be protected by a lock, no? http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: PS3: The new metrics descriptions' should mention what happens when there haven't been any reads/writes, or when the tserver is restarted. http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tserver/tablet_service.cc@2670 PS3, Line 2670: // Then the number of rows/cells/bytes actually processed. Here we have to dig As does the beginning of this comment. http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tserver/tablet_service.cc@2685 PS3, Line 2685: // First, the number of rows/cells/bytes actually returned to the user. This comment needs to be updated. -- To view, visit http://gerrit.cloudera.org:8080/14912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90738ba90eaa8f78c8d721dde2eed2b723d5572d Gerrit-Change-Number: 14912 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2019 19:55:47 +0000 Gerrit-HasComments: Yes
