Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14912 )
Change subject: [metrics] Add new metrics to indicate the last read/write time ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/14912/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14912/1//COMMIT_MSG@10 PS1, Line 10: 'last_write_elapsed_seconds' for tablet to indicate the last read or > I see, then it's especially important to separate read and write metrics. Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.h@282 PS3, Line 282: // Get the total size of all the DMS : size_t DeltaMemStoresSize() const; : : // Same as MemRowSetEmpty(), but for the DMS. : bool DeltaMemRowSetEmpty() const; : > Can these be private? Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.h@761 PS3, Line 761: std::vector<MaintenanceOp*> maintenance_ops_; : > These need to be protected by a lock, no? Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: PS3: > The new metrics descriptions' should mention what happens when there haven' Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc@167 PS3, Line 167: METRIC_DEFINE_gauge_uint64(tablet, last_read_elapsed_time, "Last Read Elapsed Seconds", > Maybe last_read_elapsed_time? That seems to be more common than listing the Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc@169 PS3, Line 169: "The elapsed time, in seconds, since the last read operation " > Maybe rephrase this to "The elapsed time, in seconds, since the last read o Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tablet/tablet.cc@173 PS3, Line 173: METRIC_DEFINE_gauge_uint64(tablet, last_write_elapsed_time, "Last Write Elapsed Seconds", > Maybe rephrase this to "The elapsed time, in seconds, since the last write Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tserver/tablet_service.cc@2670 PS3, Line 2670: // Calculate the number of rows/cells/bytes actually processed. Here we have to dig > As does the beginning of this comment. Done http://gerrit.cloudera.org:8080/#/c/14912/3/src/kudu/tserver/tablet_service.cc@2685 PS3, Line 2685: // The number of rows/cells/bytes actually returned to the user. > This comment needs to be updated. Done -- To view, visit http://gerrit.cloudera.org:8080/14912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90738ba90eaa8f78c8d721dde2eed2b723d5572d Gerrit-Change-Number: 14912 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 06:16:17 +0000 Gerrit-HasComments: Yes
