Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14912 )
Change subject: [metrics] Add new metrics to indicate the last read/write time ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/14912/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14912/4//COMMIT_MSG@7 PS4, Line 7: metrics tablet ? http://gerrit.cloudera.org:8080/#/c/14912/4//COMMIT_MSG@10 PS4, Line 10: or and http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.h File src/kudu/tablet/tablet.h: http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.h@764 PS4, Line 764: simple_spinlock Would rw_spinlock be a better option here? For read access, with rw_spinlock it's possible to use shared_lock<rw_spinlock> construct, allowing multiple readers at once. http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.cc@167 PS4, Line 167: "Last Read Elapsed Seconds" nit: maybe, "Seconds Since Last Read" for easier comprehension? http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.cc@173 PS4, Line 173: "Last Write Elapsed Seconds" nit: maybe, "Seconds Since Last Write"? http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.cc@1993 PS4, Line 1993: MonoTime::Now().GetDeltaSince(last_read_time_).ToSeconds() Would (MonoTime::Now() - last_read_time_).ToSeconds() work here? http://gerrit.cloudera.org:8080/#/c/14912/4/src/kudu/tablet/tablet.cc@2001 PS4, Line 2001: MonoTime::Now().GetDeltaSince(last_write_time_).ToSeconds() Would (MonoTime::Now() - last_write_time_).ToSeconds() work here? -- To view, visit http://gerrit.cloudera.org:8080/14912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90738ba90eaa8f78c8d721dde2eed2b723d5572d Gerrit-Change-Number: 14912 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 08:07:16 +0000 Gerrit-HasComments: Yes
