Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14977 )
Change subject: KUDU-3011 p2: mechanism to quiesce leadership ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/14977/7//COMMIT_MSG Commit Message: PS7: > With this approach when StartElection() returns an error, would it be a flo Yeah, I would rather address that in a later patch, if you don't mind -- I think throttling would be non-negligible code and would distract from this patch. http://gerrit.cloudera.org:8080/#/c/14977/7/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: PS7: > Does it make sense to add a test to verify that even with a majority of rep Done http://gerrit.cloudera.org:8080/#/c/14977/8/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/14977/8/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@72 PS8, Line 72: if (tablet_ids) { > Is it needed? Done http://gerrit.cloudera.org:8080/#/c/14977/8/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@129 PS8, Line 129: vector<string> tablet_ids; > ditto Done http://gerrit.cloudera.org:8080/#/c/14977/8/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@178 PS8, Line 178: *ts->server()->mutable_quiescing > ditto Done -- To view, visit http://gerrit.cloudera.org:8080/14977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eb3778fe094647bc5f61f97971087d7efb8af5e Gerrit-Change-Number: 14977 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 07 Jan 2020 04:09:04 +0000 Gerrit-HasComments: Yes
