Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14977 )
Change subject: KUDU-3011 p2: mechanism to quiesce leadership ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14977/4/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/14977/4/src/kudu/consensus/raft_consensus.cc@382 PS4, Line 382: WARN_NOT_OK(StartElection(NORMAL_ELECTION, INITIAL_SINGLE_NODE_ELECTION), : "Couldn't start leader election"); > Should Whoops, it seems I started some comment and left it incomplete. I was about to ask whether the single-replica scenario case should be covered by a test, i.e. making sure that a single replica tablet starts an election and elects its single replica a leader once quiescent period is over. http://gerrit.cloudera.org:8080/#/c/14977/7/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/14977/7/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@64 PS7, Line 64: hitting drop ? -- To view, visit http://gerrit.cloudera.org:8080/14977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0eb3778fe094647bc5f61f97971087d7efb8af5e Gerrit-Change-Number: 14977 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 06 Jan 2020 23:28:42 +0000 Gerrit-HasComments: Yes
