Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14977 )

Change subject: KUDU-3011 p2: mechanism to quiesce leadership
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14977/7//COMMIT_MSG
Commit Message:

PS7:
With this approach when StartElection() returns an error, would it be a flood 
of warning messages in the tablet server's logs when the tablet server enters a 
quiescent period?


http://gerrit.cloudera.org:8080/#/c/14977/7/src/kudu/integration-tests/tablet_server_quiescing-itest.cc
File src/kudu/integration-tests/tablet_server_quiescing-itest.cc:

PS7:
Does it make sense to add a test to verify that even with a majority of 
replicas in quiescent state, a tablet still can elect a leader if the election 
is started by a replica that is  in normal state?



--
To view, visit http://gerrit.cloudera.org:8080/14977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb3778fe094647bc5f61f97971087d7efb8af5e
Gerrit-Change-Number: 14977
Gerrit-PatchSet: 8
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 07 Jan 2020 00:04:40 +0000
Gerrit-HasComments: Yes

Reply via email to