Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 22: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action.cc@271 PS22, Line 271: if (program_name_) { : CHECK_NE("", google::SetCommandLineOptionWithMode("log_filename", : program_name_->c_str(), : google::FlagSettingMode::SET_FLAGS_DEFAULT)); : } Why couldn't we have just set the default in tool_action_tserver and tool_action_master? http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_master.cc@101 PS22, Line 101: RETURN_NOT_OK(master::RunMasterServer()); : return Status::OK(); nit: could just return master::RunMasterServer(); http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_tserver.cc@92 PS22, Line 92: RETURN_NOT_OK(tserver::RunTabletServer()); : return Status::OK(); nit: same here http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/util/minidump.cc@217 PS22, Line 217: !FLAGS_log_filename.empty() ? FLAGS_log_filename.c_str() : : gflags::ProgramInvocationShortName(); nit: would be clearer without the negative FLAGS_log_filename.empty() ? gflags::ProgramInvocationShortName() : FLAGS_log_filename.c_string(); -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 22 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 07 Jan 2020 05:04:55 +0000 Gerrit-HasComments: Yes
