Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 23: (4 comments) http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action.cc@271 PS22, Line 271: if (program_name_) { : CHECK_NE("", google::SetCommandLineOptionWithMode("log_filename", : program_name_->c_str(), : google::FlagSettingMode::SET_FLAGS_DEFAULT)); : } > Why couldn't we have just set the default in tool_action_tserver and tool_a I am not sure I understand the other option. I need to initialize the logging for all actions, so this is the one place to do it before each runner is called. I only need to set the program name for the master and tserver run actions so that the log files are named accordingly. The initialization was previously done in tool_main.cc http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_master.cc@101 PS22, Line 101: return master::RunMasterServer(); : } > nit: could just Done http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action_tserver.cc@92 PS22, Line 92: return tserver::RunTabletServer(); : } > nit: same here Done http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/util/minidump.cc File src/kudu/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/util/minidump.cc@217 PS22, Line 217: FLAGS_log_filename.empty() ? gflags::ProgramInvocationShortName() : : FLAGS_log_filename.c_str(); > nit: would be clearer without the negative Done -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 23 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 04:05:24 +0000 Gerrit-HasComments: Yes
