Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action.cc File src/kudu/tools/tool_action.cc: http://gerrit.cloudera.org:8080/#/c/12517/22/src/kudu/tools/tool_action.cc@271 PS22, Line 271: if (program_name_) { : CHECK_NE("", google::SetCommandLineOptionWithMode("log_filename", : program_name_->c_str(), : google::FlagSettingMode::SET_FLAGS_DEFAULT)); : } > I am not sure I understand the other option. I need to initialize the loggi I thought since only tool_action_tserver and tool_action_master were using this, we could put the SetCommandLineOptionWithMode() call into MasterRun() and TServerRun() like we do for redaction, rather than plumbing the program name through here. Is that not the case? -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 23 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2020 19:52:03 +0000 Gerrit-HasComments: Yes
