Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/12517/23//COMMIT_MSG Commit Message: PS23: I think it would be much easier for reviewers if this change was split into, e.g., the following separate patches: * changes in the {master,tablet_server}_main.cc and {master,tablet_server}_runner.{h,cc} * changes in flags validation * log_filename-related changes * tooling-related changes the new 'run' action http://gerrit.cloudera.org:8080/#/c/12517/23/src/kudu/master/master_runner.cc File src/kudu/master/master_runner.cc: http://gerrit.cloudera.org:8080/#/c/12517/23/src/kudu/master/master_runner.cc@85 PS23, Line 85: } The return statement is missing in the end of this function. http://gerrit.cloudera.org:8080/#/c/12517/23/src/kudu/tserver/tablet_server_runner.cc File src/kudu/tserver/tablet_server_runner.cc: http://gerrit.cloudera.org:8080/#/c/12517/23/src/kudu/tserver/tablet_server_runner.cc@81 PS23, Line 81: } The return statement is missing in the end of this function. -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 23 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2020 21:47:58 +0000 Gerrit-HasComments: Yes
