Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15012 )
Change subject: KUDU-3011 p5: transfer leadership when quiescing ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_queue.h@552 PS3, Line 552: std::atomic<bool>* server_quiescing_ nit: can this be a const pointer? http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@314 PS3, Line 314: const auto& ts_uuid = ts_and_details.first; : if (ts_uuid != leader_uuid) { : const auto* ts_details = ts_and_details.second; : ASSERT_OK(DeleteTablet(ts_details, tablet_id, : tablet::TabletDataState::TABLET_DATA_TOMBSTONED, : kTimeout)); : ASSERT_EVENTUALLY([&] { : vector<string> running_tablets; : ASSERT_OK(ListRunningTabletIds(ts_details, kTimeout, &running_tablets)); : ASSERT_EQ(0, running_tablets.size()); : }); : } Is this stable enough to avoid situations when 2 out of 3 replicas are removed before the catalog manager can spawn a replacement? Or tombstoned voting helps to avoid such a situation? http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@512 PS3, Line 512: // We should continue to write uninterrupted. How do we know that all 3 tablet servers are not in some sort of transitional state, so those extra 1000 rows inserted is not a fluke? -- To view, visit http://gerrit.cloudera.org:8080/15012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf0716f5c9455f83ff5f6f601b0f5042f77d078 Gerrit-Change-Number: 15012 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 13 Jan 2020 19:59:24 +0000 Gerrit-HasComments: Yes
