Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15012 )
Change subject: KUDU-3011 p5: transfer leadership when quiescing ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/consensus/consensus_queue-test.cc@277 PS5, Line 277: RaftConfigPB config = BuildRaftConfigPBForTests(/*num_voters*/2); > Not actually used? Ah yeah, we need to implement NotifyCommitIndex() since it gets called. I'll update this so everything else is a no-op. http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/consensus/consensus_queue-test.cc@278 PS5, Line 278: queue_->SetLeaderMode(kMinimumOpIdIndex, kMinimumTerm, config); > Should generally prefer deque to list. Done http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@525 PS5, Line 525: u > u Done -- To view, visit http://gerrit.cloudera.org:8080/15012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf0716f5c9455f83ff5f6f601b0f5042f77d078 Gerrit-Change-Number: 15012 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 15 Jan 2020 19:56:58 +0000 Gerrit-HasComments: Yes
