Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15012 )
Change subject: KUDU-3011 p5: transfer leadership when quiescing ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/consensus/consensus_queue-test.cc@277 PS5, Line 277: list<int64_t> commit_indexes_; Not actually used? http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/consensus/consensus_queue-test.cc@278 PS5, Line 278: list<string> peers_to_start_election_; Should generally prefer deque to list. http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15012/5/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@525 PS5, Line 525: U u -- To view, visit http://gerrit.cloudera.org:8080/15012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf0716f5c9455f83ff5f6f601b0f5042f77d078 Gerrit-Change-Number: 15012 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 15 Jan 2020 19:48:39 +0000 Gerrit-HasComments: Yes
