Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15012 )
Change subject: KUDU-3011 p5: transfer leadership when quiescing ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_peers-test.cc File src/kudu/consensus/consensus_peers-test.cc: http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_peers-test.cc@106 PS3, Line 106: nullptr, Nit: inline comment to annotate this? http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_queue-test.cc@76 PS3, Line 76: class ConsensusQueueTest : public KuduTest { Would it be useful to add a targeted "unit" test here to check the conditions in TransferLeadershipIfNeeded? http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/consensus/consensus_queue-test.cc@112 PS3, Line 112: nullptr, Same. http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@177 PS3, Line 177: ; extra semicolon http://gerrit.cloudera.org:8080/#/c/15012/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@346 PS3, Line 346: SleepFor(MonoDelta::FromSeconds(1)); : ASSERT_EQ(0, leader_ts->server()->num_raft_leaders()->value()); : TServerDetails* new_leader_details; : ASSERT_OK(FindTabletLeader(ts_map_, tablet_id, kTimeout, &new_leader_details)); : ASSERT_NE(leader_uuid, new_leader_details->uuid()); Why a sleep followed by a hard ASSERT? Why not an ASSERT_EVENTUALLY for the asserts in here? -- To view, visit http://gerrit.cloudera.org:8080/15012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf0716f5c9455f83ff5f6f601b0f5042f77d078 Gerrit-Change-Number: 15012 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jan 2020 05:55:58 +0000 Gerrit-HasComments: Yes
