Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: [master] KUDU-3016 flag for chunking tablet report updates ...................................................................... Patch Set 9: (2 comments) There's still an outstanding question from PS6. http://gerrit.cloudera.org:8080/#/c/14897/9/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14897/9/src/kudu/master/catalog_manager.cc@282 PS9, Line 282: DEFINE_bool(catalog_manager_enable_chunked_tablet_reports, false, Why shouldn't this default to true from day one? http://gerrit.cloudera.org:8080/#/c/14897/9/src/kudu/master/catalog_manager.cc@4307 PS9, Line 4307: PREDICT_FALSE(FLAGS_catalog_manager_enable_chunked_tablet_reports) PREDICT_FALSE seems like it'd become stale if/when the gflag's default value changes. -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jan 2020 05:47:15 +0000 Gerrit-HasComments: Yes
