Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: [master] KUDU-3016 don't lump together updates on all tablet reports ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/14897/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14897/6/src/kudu/master/catalog_manager.cc@4305 PS6, Line 4305: release the locks. : tablets_lock.Commit(); > These are UPDATE statements, so the chunk 1 of 2 in the retry report will r Right; I was asking from a performance standpoint though: if chunk N fails and all chunks are retried in the subsequent report, does the writing of chunks 0..N-1 no-op? I know there's code in SysCatalog to try and recognize that case and short-circuit; I just wasn't sure whether it applied here too. http://gerrit.cloudera.org:8080/#/c/14897/8/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14897/8/src/kudu/master/sys_catalog.cc@533 PS8, Line 533: WriteResponsePB resp; Not used? http://gerrit.cloudera.org:8080/#/c/14897/8/src/kudu/master/sys_catalog.cc@933 PS8, Line 933: genereated generated -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 14 Jan 2020 01:02:11 +0000 Gerrit-HasComments: Yes
