Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 )
Change subject: [master] KUDU-3016 don't lump together updates on all tablet reports ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/14897/6/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14897/6/src/kudu/master/sys_catalog.cc@838 PS6, Line 838: size_t req_size = req->ByteSizeLong(); > Yup, it seems calling ByteSizeLong() every iteration is expensive since it' Oh I missed that; yeah something like Pop() seems like it'd be OK. -- To view, visit http://gerrit.cloudera.org:8080/14897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83e8ca4bc8db7cab8fee6b4a40f48adc8752e7c5 Gerrit-Change-Number: 14897 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 10 Jan 2020 22:24:50 +0000 Gerrit-HasComments: Yes
