Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Refactor table names in catalog manager ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util-test.cc File src/kudu/common/table_util-test.cc: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util-test.cc@71 PS7, Line 71: ASSERT_OK(ParseRangerTableIdentifier(table, &db, &tbl)); You can use EXPECT_OK in lieu of ASSERT_OK if you want the rest of the test to continue running after the failure. http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util.h File src/kudu/common/table_util.h: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util.h@40 PS7, Line 40: Status ParseRangerTableIdentifier(const std::string& table_name, Should doc. http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util.cc File src/kudu/common/table_util.cc: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util.cc@97 PS7, Line 97: if (ranger_table->empty() || ranger_database->empty()) { Are these conditions actually possible given the code in L85-95? I don't see how. http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/master/sentry_authz_provider.cc@348 PS7, Line 348: string normalized_ident = CatalogManager::NormalizeTableName(table_ident); If this normalization is now Sentry only, could you move this method into sentry_authz_provider? -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 17 Jan 2020 00:07:47 +0000 Gerrit-HasComments: Yes
