Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15014 )
Change subject: [metrics] Fix bugs when metrics do merge ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15014/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15014/1//COMMIT_MSG@8 PS1, Line 8: : 1. METRIC_merged_entities_count_of_server should never retire. : 2. Add METRIC_merged_entities_count_of_tablet/ta > What happens when the tablet or table is deleted though, and its underlying I took a misunderstanding of "never retire", these metrics will not retire after tablet shutdown. I think the correct method is to add ref counter to these metrics, I've done that now. http://gerrit.cloudera.org:8080/#/c/15014/1/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/15014/1/src/kudu/util/metrics.h@1106 PS1, Line 1106: void set_value(const T& value) { > This shouldn't be virtual; there are no subclasses of AtomicGauge. Done http://gerrit.cloudera.org:8080/#/c/15014/1/src/kudu/util/metrics.h@1114 PS1, Line 1114: void IncrementBy(int64_t amount) { > Likewise. Done http://gerrit.cloudera.org:8080/#/c/15014/1/src/kudu/util/metrics.h@1251 PS1, Line 1251: std::lock_guard<simple_spinlock> l(lock_); > Since the value of a FunctionGauge isn't stored anywhere, we can't track wh Got it. -- To view, visit http://gerrit.cloudera.org:8080/15014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ee6244964820e3326742c6902a578bf23041d1 Gerrit-Change-Number: 15014 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 14 Jan 2020 08:26:53 +0000 Gerrit-HasComments: Yes
