Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15014 )
Change subject: [metrics] Fix bugs when metrics do merge ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15014/2/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: http://gerrit.cloudera.org:8080/#/c/15014/2/src/kudu/master/table_metrics.cc@23 PS2, Line 23: METRIC_DECLARE_gauge_size(merged_entities_count_of_table); > merged_entities_count_of_xx is defined in metrics.h:L266, in METRIC_DEFINE_ Ah I forgot about that. Thanks for the reminder. -- To view, visit http://gerrit.cloudera.org:8080/15014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ee6244964820e3326742c6902a578bf23041d1 Gerrit-Change-Number: 15014 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2020 19:39:59 +0000 Gerrit-HasComments: Yes
