Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15014 )
Change subject: [metrics] Fix bugs when metrics do merge ...................................................................... [metrics] Fix bugs when metrics do merge 1. METRIC_merged_entities_count_of_server should never retire. 2. Add METRIC_merged_entities_count_of_tablet/table's ref counter to avoid retiring before its bounded MetricEntity destroyed. 3. Metric's modification epoch should be updated when AtomicGauge set_value(). 4. Merge should abort if metrics are invalid for merging, FunctionGauge included. Change-Id: I36ee6244964820e3326742c6902a578bf23041d1 Reviewed-on: http://gerrit.cloudera.org:8080/15014 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/master/catalog_manager.cc M src/kudu/master/table_metrics.cc M src/kudu/master/table_metrics.h M src/kudu/server/server_base.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_metrics.cc M src/kudu/tablet/tablet_metrics.h M src/kudu/util/metrics.h 8 files changed, 24 insertions(+), 8 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I36ee6244964820e3326742c6902a578bf23041d1 Gerrit-Change-Number: 15014 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]>
