Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15014 )
Change subject: [metrics] Fix bugs when metrics do merge ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15014/2/src/kudu/master/table_metrics.cc File src/kudu/master/table_metrics.cc: http://gerrit.cloudera.org:8080/#/c/15014/2/src/kudu/master/table_metrics.cc@23 PS2, Line 23: METRIC_DECLARE_gauge_size(merged_entities_count_of_table); > Could you move the prototype definition into this file too, and put it on L merged_entities_count_of_xx is defined in metrics.h:L266, in METRIC_DEFINE_entity macro, seems not easy to split. http://gerrit.cloudera.org:8080/#/c/15014/2/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/15014/2/src/kudu/tablet/tablet_metrics.cc@315 PS2, Line 315: METRIC_DECLARE_gauge_size(merged_entities_count_of_tablet); > Same; could you move the definition here? Same. -- To view, visit http://gerrit.cloudera.org:8080/15014 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36ee6244964820e3326742c6902a578bf23041d1 Gerrit-Change-Number: 15014 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2020 01:57:42 +0000 Gerrit-HasComments: Yes
