Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Add semi-database support for Ranger ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/15018/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15018/9//COMMIT_MSG@17 PS9, Line 17: case : sensitive > nit: should this be updated? Done http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.h File src/kudu/common/table_util.h: http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.h@40 PS10, Line 40: // Parses a Kudu table name of the form '<database>.<table>' into a > Doc. Done http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.cc File src/kudu/common/table_util.cc: http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.cc@102 PS10, Line 102: *ranger_database = FLAGS_ranger_default_database; > You can combine the two calls to assign to *default_database after the if: Done -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 06 Feb 2020 19:30:05 +0000 Gerrit-HasComments: Yes
