Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Add semi-database support for Ranger ...................................................................... Patch Set 10: (6 comments) A few nits http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc File src/kudu/common/table_util-test.cc: http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@77 PS10, Line 77: my_awesome/table/22 What if the database name is something containing the '/' symbol? Is it a valid identified for ParseRangerTableIdentifier()? http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@89 PS10, Line 89: "foo" Does it make sense to add a test for parsing 'default.foo'? Is it recognized as a default database? http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@103 PS10, Line 103: EXPECT_OK(ParseRangerTableIdentifier("no_table", &db, &tbl, &default_database)); It think it would be nice to add a test for 'db_name..table_name' as well. http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@105 PS10, Line 105: EXPECT_TRUE(ParseRangerTableIdentifier(".no_table", &db, &tbl, &default_database).IsInvalidArgument()); It seems line 105 can be removed since there is also line 107 http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@110 PS10, Line 110: unicode☃tables what about unicode characters in the table, not database names? http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@111 PS10, Line 111: \0.\0 That's great to be able to parse this, but does Ranger accept this as a valid table name? -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 06 Feb 2020 18:26:29 +0000 Gerrit-HasComments: Yes
