Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Add semi-database support for Ranger ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util-test.cc File src/kudu/common/table_util-test.cc: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/common/table_util-test.cc@71 PS7, Line 71: table = "foo.bar"; > You can use EXPECT_OK in lieu of ASSERT_OK if you want the rest of the test Done http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/15018/7/src/kudu/master/sentry_authz_provider.cc@348 PS7, Line 348: RETURN_NOT_OK(fetcher_.GetSentryPrivileges(scope, table_ident, user, > If this normalization is now Sentry only, could you move this method into s it wasn't Sentry-only, we had to use it in catalog manager as well to make sure there are no naming conflicts. Now it's back to normalize everywhere anyway so I'm marking this as resolved. -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 06 Feb 2020 17:25:22 +0000 Gerrit-HasComments: Yes
