Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 )
Change subject: KUDU-2973 Add semi-database support for Ranger ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc File src/kudu/common/table_util-test.cc: http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util-test.cc@65 PS10, Line 65: TEST(TestTableUtil, TestRangerTableIdentifier) { Some of the lines look like they're too long. http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.h File src/kudu/common/table_util.h: http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.h@40 PS10, Line 40: Status ParseRangerTableIdentifier(const std::string& table_name, Doc. http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.cc File src/kudu/common/table_util.cc: http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.cc@29 PS10, Line 29: DEFINE_string(ranger_default_database, "default", Why does this need to be configurable? Under what circumstances would 'default' be inappropriate here? http://gerrit.cloudera.org:8080/#/c/15018/10/src/kudu/common/table_util.cc@102 PS10, Line 102: *default_database = true; You can combine the two calls to assign to *default_database after the if: *default_database = !separator_idx; -- To view, visit http://gerrit.cloudera.org:8080/15018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11431ff5bc75540edff56ef3d4ad384fa37d33d5 Gerrit-Change-Number: 15018 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 06 Feb 2020 18:01:48 +0000 Gerrit-HasComments: Yes
