Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15317
to look at the new patch set (#2).
Change subject: [thirdparty] bump cmake version up to 3.11.4
......................................................................
[thirdparty] bump cmake version up to 3.11.4
As it turned out, cmake versions prior to 3.11.2 had issues while
building Kudu with OpenJDK 11: cmake expects the 'javah' binary to be
present in JDK, but that's not the case since JDK 10. This patch
updates cmake in thirdparty up to the latest version in the 3.11.x
lineage: 3.11.4.
In addition, this patch disables building/running cmake tests: Adar
provided a recipe to do so while looking at 3.16.4 compilation issue.
NOTE: I tried to bump cmake version up to 3.16.4, but there was
an issue with compiling it under CentOS6 with devtoolset-3.
Since 3.11.4 works fine for the purpose, I'm not sure it makes
much sense spending time on digging in and making 3.16.4 compiling
with devtoolset on CentOS6, where the latter is going to be
deprecated soon anyway (scheduled EOL is November 30, 2020).
NOTE: Adar took a closer look at the 3.16.4 compilation issue and
filed the following issue for cmake upstream:
https://gitlab.kitware.com/cmake/cmake/issues/20401
NOTE: if both pre-JDK 10 and OpenJDK 11 are installed, the issue is not
manifesting itself; the issue appears only if OpenJDK 10/11 is the
only Java version installed at the build machine.
Change-Id: I1596f6127e3fc6d5715220bb39f1a893c8a8a8ae
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
3 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/15317/2
--
To view, visit http://gerrit.cloudera.org:8080/15317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1596f6127e3fc6d5715220bb39f1a893c8a8a8ae
Gerrit-Change-Number: 15317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
