Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15317 )
Change subject: [thirdparty] bump cmake version up to 3.11.4 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15317/2/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15317/2/CMakeLists.txt@18 PS2, Line 18: # Require cmake that can: This doesn't need to be a "log"; let's only keep track of the latest reason (that is, the motivating factor for the latest upgradE). http://gerrit.cloudera.org:8080/#/c/15317/2/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/15317/2/thirdparty/vars.sh@63 PS2, Line 63: CMAKE_VERSION=3.11.4 Given that you've set -DBUILD_TESTING=OFF, could we use 3.16.4 instead? In general we should prefer newer versions of dependencies. -- To view, visit http://gerrit.cloudera.org:8080/15317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1596f6127e3fc6d5715220bb39f1a893c8a8a8ae Gerrit-Change-Number: 15317 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 22:50:04 +0000 Gerrit-HasComments: Yes
