Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15317 )
Change subject: [thirdparty] bump cmake version up to 3.11.4 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15317/2/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/15317/2/thirdparty/vars.sh@63 PS2, Line 63: CMAKE_VERSION=3.11.4 > I was not sure whether we want to use a dependency when we know it doesn't I mean, I don't consider -DBUILD_TESTING=OFF to be a trick. I'm sure you could find other examples of dependencies that, were it not for a command line option used in build-definitions.sh, also wouldn't build. In general, we should prefer newer versions of dependencies because they tend to be more featureful, have fewer security vulnerabilities, etc. In some specific cases we need to be more careful (e.g. if a dep is used on the hot path), but I don't think that's the case here. -- To view, visit http://gerrit.cloudera.org:8080/15317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1596f6127e3fc6d5715220bb39f1a893c8a8a8ae Gerrit-Change-Number: 15317 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 23:38:19 +0000 Gerrit-HasComments: Yes
