Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15317 )

Change subject: [thirdparty] bump cmake version up to 3.16.4
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15317/2/CMakeLists.txt
File CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/15317/2/CMakeLists.txt@18
PS2, Line 18: # Require cmake that can:
> This doesn't need to be a "log"; let's only keep track of the latest reason
Done


http://gerrit.cloudera.org:8080/#/c/15317/2/thirdparty/vars.sh
File thirdparty/vars.sh:

http://gerrit.cloudera.org:8080/#/c/15317/2/thirdparty/vars.sh@63
PS2, Line 63: CMAKE_VERSION=3.11.4
> I mean, I don't consider -DBUILD_TESTING=OFF to be a trick. I'm sure you co
Thank you for the clarification.

I updated the version to be 3.16.4



--
To view, visit http://gerrit.cloudera.org:8080/15317
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1596f6127e3fc6d5715220bb39f1a893c8a8a8ae
Gerrit-Change-Number: 15317
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Sat, 29 Feb 2020 00:18:38 +0000
Gerrit-HasComments: Yes

Reply via email to