Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15387 )
Change subject: replace gscoped_ptr with std::unique_ptr ...................................................................... Patch Set 1: (3 comments) It seems IWYU is not happy: 01:28:10 >>> Fixing #includes in '/home/jenkins-slave/workspace/kudu-master/3/src/kudu/rpc/rpc-test.cc' 01:28:10 @@ -46,7 +46,6 @@ 01:28:10 #include "kudu/rpc/reactor.h" 01:28:10 #include "kudu/rpc/rpc-test-base.h" 01:28:10 #include "kudu/rpc/rpc_controller.h" 01:28:10 -#include "kudu/rpc/rpc_header.pb.h" 01:28:10 #include "kudu/rpc/rpc_introspection.pb.h" 01:28:10 #include "kudu/rpc/rpc_sidecar.h" 01:28:10 #include "kudu/rpc/rtest.pb.h" 01:28:10 IWYU would have edited 1 files on your behalf. 01:28:10 01:28:10 make[3]: *** [CMakeFiles/iwyu] Error 1 01:28:10 make[2]: *** [CMakeFiles/iwyu.dir/all] Error 2 01:28:10 make[1]: *** [CMakeFiles/iwyu.dir/rule] Error 2 01:28:10 make: *** [iwyu] Error 2 http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/client/meta_cache.cc@91 PS1, Line 91: nit: drop the extra space? http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/rowset_tree.h File src/kudu/tablet/rowset_tree.h: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/rowset_tree.h@114 PS1, Line 114: nit: drop the extra space http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/tablet_metadata.h@372 PS1, Line 372: // We don't use unique_ptr so that we can do an atomic swap. nit: not sure this is relevant to gscoped_ptr/unique_ptr only, so maybe either drop this line at all or mention it's about non-trivial wrappers around raw pointers? -- To view, visit http://gerrit.cloudera.org:8080/15387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a35557b49dba7cc6a0c131841ae3c96230bb2fc Gerrit-Change-Number: 15387 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 09 Mar 2020 17:49:48 +0000 Gerrit-HasComments: Yes
