Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15387 )
Change subject: replace gscoped_ptr with std::unique_ptr ...................................................................... replace gscoped_ptr with std::unique_ptr The remaining usages are in gutil, where we've imported code wholesale which contained gscoped_ptr and I'm loathe to remove it right now. Given the high number of touched files, there are also a fair number of iwyu and clang-tidy fixups in this patch. Change-Id: I9a35557b49dba7cc6a0c131841ae3c96230bb2fc Reviewed-on: http://gerrit.cloudera.org:8080/15387 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M docs/design-docs/cpp-client.md M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc M src/kudu/benchmarks/tpch/rpc_line_item_dao.h M src/kudu/benchmarks/tpch/tpch1.cc M src/kudu/benchmarks/tpch/tpch_real_world.cc M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/block_cache.cc M src/kudu/cfile/block_cache.h M src/kudu/cfile/bshuf_block.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_reader.h M src/kudu/cfile/cfile_writer.h M src/kudu/cfile/encoding-test.cc M src/kudu/cfile/index-test.cc M src/kudu/client/client.cc M src/kudu/client/master_rpc.cc M src/kudu/client/meta_cache.cc M src/kudu/client/predicate-test.cc M src/kudu/client/scan_predicate.cc M src/kudu/client/scan_token-test.cc M src/kudu/client/schema.cc M src/kudu/client/write_op.cc M src/kudu/codegen/code_cache.cc M src/kudu/codegen/code_cache.h M src/kudu/codegen/code_generator.cc M src/kudu/codegen/codegen-test.cc M src/kudu/codegen/compilation_manager.cc M src/kudu/codegen/compilation_manager.h M src/kudu/consensus/consensus-test-util.h M src/kudu/consensus/consensus_peers-test.cc M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_peers.h M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/leader_election-test.cc M src/kudu/consensus/leader_election.h M src/kudu/consensus/log-test-base.h M src/kudu/consensus/log-test.cc M src/kudu/consensus/log.cc M src/kudu/consensus/log.h M src/kudu/consensus/log_cache-test.cc M src/kudu/consensus/peer_manager.cc M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/consensus/ref_counted_replicate.h M src/kudu/gutil/map-util.h M src/kudu/gutil/ref_counted.h M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/catalog_manager_tsk-itest.cc M src/kudu/integration-tests/client-stress-test.cc M src/kudu/integration-tests/consensus_peer_health_status-itest.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/decimal-itest.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/location_assignment-itest.cc M src/kudu/integration-tests/master_replication-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/raft_consensus_stress-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/security-faults-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/update_scan_delta_compact-test.cc M src/kudu/integration-tests/write_throttling-itest.cc M src/kudu/kserver/kserver.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/master-test.cc M src/kudu/master/sys_catalog-test.cc M src/kudu/master/ts_descriptor.h M src/kudu/mini-cluster/internal_mini_cluster.cc M src/kudu/rpc/connection.cc M src/kudu/rpc/rpc-test.cc M src/kudu/server/glog_metrics.h M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/compaction.h M src/kudu/tablet/delta_compaction-test.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_compaction.h M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/delta_tracker.h M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/local_tablet_writer.h M src/kudu/tablet/lock_manager.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/multi_column_writer.cc M src/kudu/tablet/row_op.cc M src/kudu/tablet/row_op.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_tree.cc M src/kudu/tablet/rowset_tree.h M src/kudu/tablet/tablet-harness.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet.h M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tablet/tablet_metadata.h M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tablet/tablet_replica-test.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica.h M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/transaction_tracker-test.cc M src/kudu/tablet/transactions/transaction_tracker.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/util/bit-stream-utils.h M src/kudu/util/bit-stream-utils.inline.h M src/kudu/util/rle-encoding.h 146 files changed, 679 insertions(+), 818 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/15387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9a35557b49dba7cc6a0c131841ae3c96230bb2fc Gerrit-Change-Number: 15387 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
