Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15387 )
Change subject: replace gscoped_ptr with std::unique_ptr ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/client/meta_cache.cc@91 PS1, Line 91: > nit: drop the extra space? Done http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/rowset_tree.h File src/kudu/tablet/rowset_tree.h: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/rowset_tree.h@114 PS1, Line 114: > nit: drop the extra space Done http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/tablet_metadata.h@372 PS1, Line 372: // We don't use unique_ptr so that we can do an atomic swap. > nit: not sure this is relevant to gscoped_ptr/unique_ptr only, so maybe eit I think it is relevant; see this code in SetSchemaUnlocked: Schema* old_schema = schema_; // "Release" barrier ensures that, when we publish the new Schema object, // all of its initialization is also visible. base::subtle::Release_Store(reinterpret_cast<AtomicWord*>(&schema_), reinterpret_cast<AtomicWord>(new_schema.release())); if (PREDICT_TRUE(old_schema)) { old_schemas_.push_back(old_schema); } -- To view, visit http://gerrit.cloudera.org:8080/15387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a35557b49dba7cc6a0c131841ae3c96230bb2fc Gerrit-Change-Number: 15387 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 09 Mar 2020 22:47:51 +0000 Gerrit-HasComments: Yes
