Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15387 )
Change subject: replace gscoped_ptr with std::unique_ptr ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/15387/1/src/kudu/tablet/tablet_metadata.h@372 PS1, Line 372: // We don't use unique_ptr so that we can do an atomic swap. > I think it is relevant; see this code in SetSchemaUnlocked: OK, if it's referring to the signature of TabletMetadata::SetSchemaUnlocked(), then it seems reasonable. -- To view, visit http://gerrit.cloudera.org:8080/15387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a35557b49dba7cc6a0c131841ae3c96230bb2fc Gerrit-Change-Number: 15387 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 10 Mar 2020 00:07:09 +0000 Gerrit-HasComments: Yes
