Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15437 )

Change subject: [build] address compilation warnings from GCC 8.3.1
......................................................................


Patch Set 1: Verified+1

unrelated build fluke in IWYU:

14:14:19 CMake Error at CMakeLists.txt:782 (file):
14:14:19   file COPY cannot copy file
14:14:19   
"/home/jenkins-slave/workspace/kudu-master/2/src/kudu/client/../scripts/first_argument.sh"
14:14:19   to
14:14:19   
"/home/jenkins-slave/workspace/kudu-master/2/build/iwyu/bin/testdata/first_argument.sh":
14:14:19   Success.
14:14:19 Call Stack (most recent call first):
14:14:19   src/kudu/client/CMakeLists.txt:268 (ADD_KUDU_TEST)


However, I verified that IWYU is happy with this change (CentOS 6.6):

2020-03-14 15:19:15,141 INFO: Checking 2 file(s)...
IWYU would have edited 0 files on your behalf.

Built target iwyu


--
To view, visit http://gerrit.cloudera.org:8080/15437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc1ff1bbba48846d91c39c2a53ff0ead1bf3f513
Gerrit-Change-Number: 15437
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Mar 2020 22:21:06 +0000
Gerrit-HasComments: No

Reply via email to