Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 )
Change subject: [build] address compilation warnings from GCC 8.3.1 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15437/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15437/1//COMMIT_MSG@24 PS1, Line 24: unctional modifications, it only fixes : the warnings above. > Yes, this is also an option. I don't see much difference there, except for Sorry for not being clear, I put double quotes around cheaper to imply LOC (rather than actual performance). -- To view, visit http://gerrit.cloudera.org:8080/15437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc1ff1bbba48846d91c39c2a53ff0ead1bf3f513 Gerrit-Change-Number: 15437 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 21:41:11 +0000 Gerrit-HasComments: Yes
