Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15437 )
Change subject: [build] address compilation warnings from GCC 8.3.1 ...................................................................... [build] address compilation warnings from GCC 8.3.1 While compiling on CentOS 8.1 with GCC 8.3.1, the following warnings were observed: src/kudu/util/env_posix.cc:1523:11: warning: unnecessary parentheses in declaration of ‘paths’ [-Wparentheses] char *(paths[]) = { name_dup.get(), nullptr }; src/kudu/tablet/concurrent_btree.h: In instantiation of ‘void kudu::tablet::btree::CBTreeIterator<Traits>::SeekToLeaf(const kudu::Slice&) [with Traits = kudu::tablet::btree::SmallFanoutTraits]’: src/kudu/tablet/concurrent_btree.h:1624:5: required from ‘bool kudu::tablet::btree::CBTreeIterator<Traits>::SeekAtOrAfter(const kudu::Slice&, bool*) [with Traits = kudu::tablet::btree::SmallFanoutTraits]’ src/kudu/tablet/cbtree-test.cc:502:5: required from here src/kudu/tablet/concurrent_btree.h:1792:15: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘class kudu::tablet::btree::LeafNode<kudu::tablet::btree::SmallFanoutTraits>’ with no trivial copy-assignment [-Wclass-memaccess] memcpy(&leaf_copy_, leaf, sizeof(leaf_copy_)); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/kudu/tablet/concurrent_btree.h:677:7: note: ‘class kudu::tablet::btree::LeafNode<kudu::tablet::btree::SmallFanoutTraits>’ declared here class LeafNode : public NodeBase<Traits> { This patch doesn't contain any functional modifications, it only fixes the warnings above. Change-Id: Ifc1ff1bbba48846d91c39c2a53ff0ead1bf3f513 Reviewed-on: http://gerrit.cloudera.org:8080/15437 Tested-by: Alexey Serbin <aser...@cloudera.com> Reviewed-by: Adar Dembo <a...@cloudera.com> --- M src/kudu/tablet/concurrent_btree.h M src/kudu/util/env_posix.cc 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alexey Serbin: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifc1ff1bbba48846d91c39c2a53ff0ead1bf3f513 Gerrit-Change-Number: 15437 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)