Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 )
Change subject: [build] address compilation warnings from GCC 8.3.1 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15437/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15437/1//COMMIT_MSG@24 PS1, Line 24: squelches the latter with a pragma to : ignore the -Wclass-memaccess warning. > +1 Yes, this is also an option. I don't see much difference there, except for ignored warnings directives explicitly signals there might be some dragons when reading the code. Not sure it's 'cheaper', maybe only in number of lines of code :) OK, let's replace with static_cast. -- To view, visit http://gerrit.cloudera.org:8080/15437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc1ff1bbba48846d91c39c2a53ff0ead1bf3f513 Gerrit-Change-Number: 15437 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 20:28:31 +0000 Gerrit-HasComments: Yes
