Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@42 PS7, Line 42: : DEFINE_string(ranger_java_path, "java", : "The path where the Java binary was installed. If " : "the value isn't an absolute path, it will be evaluated " : "using the Kudu user's PATH."); : TAG_FLAG(ranger_java_path, experimental); We'll probably want to centralize this, if it'll be reused for other JVM-based subprocesses (like Atlas). Doesn't have to happen now, but keep in mind. http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@203 PS7, Line 203: argv->emplace_back(configured_principal); Can std::move() http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@222 PS7, Line 222: subprocess_.reset(new RangerSubprocess(argv, metric_entity_)); Can std::move(argv). -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 16 Mar 2020 06:45:07 +0000 Gerrit-HasComments: Yes
