Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@42 PS7, Line 42: #include "kudu/util/subprocess.h" : : DEFINE_string(ranger_java_path, "java", : "The path where the Java binary was installed. If " : "the value isn't an absolute path, it will be evaluated " : "using the Kudu user's PATH > We'll probably want to centralize this, if it'll be reused for other JVM-ba Ack http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@200 PS7, Line 200: > nit: parentheses usually denote something that is optional, which doesn't s Done http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@203 PS7, Line 203: GROUP_FLAG_VALIDATOR(ranger_config_flags, ValidateRangerConfiguration); > Can std::move() Done http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@202 PS7, Line 202: : GROUP_FLAG_VALIDATOR(ranger_config_flags, ValidateRangerConfiguration); : : #define HISTINIT(member, x) member = METRI > These should be 'ret'. Done http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@222 PS7, Line 222: } > Can std::move(argv). Done http://gerrit.cloudera.org:8080/#/c/15416/8/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/8/src/kudu/ranger/ranger_client.cc@169 PS8, Line 169: ret.emplace_back("-i"); > warning: std::move of the const expression of the trivially-copyable type ' Done http://gerrit.cloudera.org:8080/#/c/15416/8/src/kudu/ranger/ranger_client.cc@171 PS8, Line 171: ret.emplace_back("-k"); > warning: std::move of the const expression of the trivially-copyable type ' Done -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Mar 2020 01:10:54 +0000 Gerrit-HasComments: Yes
